[Asterisk-code-review] core / pjsip: Add support for grouping streams together. (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6936 )

Change subject: core / pjsip: Add support for grouping streams together.
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.asterisk.org/#/c/6936/3/main/stream.c
File main/stream.c:

https://gerrit.asterisk.org/#/c/6936/3/main/stream.c@70
PS3, Line 70: 	 * \brief The group that the stream is part of
            : 	 */
            : 	int group;
> I think things could be simplified by moving the msid/mslabel stuff onto th
I didn't want to cross that barrier and move protocol knowledge (mslabel, msid) into the stream API. I wanted to keep it simple and easier to consume. I don't think the core should have to know it. Just that they are part of the same group.


https://gerrit.asterisk.org/#/c/6936/3/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/6936/3/res/res_pjsip_session.c@611
PS3, Line 611: 		if (ast_strlen_zero(group_session_media->remote_mslabel) ||
             : 			strcmp(group_session_media->remote_mslabel, session_media->remote_mslabel)) {
> If the remote_mslabel is derived from the msid this may not match sometimes
That does get broken apart above in the msid handling. The strsep separates it. The first being the mslabel, the second behind the track.



-- 
To view, visit https://gerrit.asterisk.org/6936
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6299aa031efe46254edbdc7973c534d54d641ad
Gerrit-Change-Number: 6936
Gerrit-PatchSet: 3
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 31 Oct 2017 16:43:59 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171031/417a9e54/attachment.html>