[Asterisk-code-review] core / pjsip: Add support for grouping streams together. (asterisk[15])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/6936 )

Change subject: core / pjsip: Add support for grouping streams together.
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/6936/2/main/cli.c
File main/cli.c:

https://gerrit.asterisk.org/#/c/6936/2/main/cli.c@1693
PS2, Line 1693: 			"    Group: %u\n"
Why unsigned? ast_stream_get_group() returns a signed int.


https://gerrit.asterisk.org/#/c/6936/2/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/6936/2/res/res_pjsip_session.c@574
PS2, Line 574: 		if (!pj_strcmp2(&attr->name, "msid")) {
Use a static pj_str_t and pj_strcmp()


https://gerrit.asterisk.org/#/c/6936/2/res/res_pjsip_session.c@579
PS2, Line 579: 		} else if (!pj_strcmp2(&attr->name, "ssrc")) {
Use a static pj_str_t and pj_strcmp()


https://gerrit.asterisk.org/#/c/6936/2/res/res_pjsip_session.c@616
PS2, Line 616:         }
Bad indent



-- 
To view, visit https://gerrit.asterisk.org/6936
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6299aa031efe46254edbdc7973c534d54d641ad
Gerrit-Change-Number: 6936
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 30 Oct 2017 22:04:09 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171030/7c3620d4/attachment.html>