<p>Sean Bright <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6936">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6936/2/main/cli.c">File main/cli.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6936/2/main/cli.c@1693">Patch Set #2, Line 1693:</a> <code style="font-family:monospace,monospace">                       "    Group: %u\n"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why unsigned? ast_stream_get_group() returns a signed int.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6936/2/res/res_pjsip_session.c">File res/res_pjsip_session.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6936/2/res/res_pjsip_session.c@574">Patch Set #2, Line 574:</a> <code style="font-family:monospace,monospace">           if (!pj_strcmp2(&attr->name, "msid")) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use a static pj_str_t and pj_strcmp()</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6936/2/res/res_pjsip_session.c@579">Patch Set #2, Line 579:</a> <code style="font-family:monospace,monospace">                } else if (!pj_strcmp2(&attr->name, "ssrc")) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use a static pj_str_t and pj_strcmp()</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6936/2/res/res_pjsip_session.c@616">Patch Set #2, Line 616:</a> <code style="font-family:monospace,monospace">        }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Bad indent</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6936">change 6936</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6936"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id6299aa031efe46254edbdc7973c534d54d641ad </div>
<div style="display:none"> Gerrit-Change-Number: 6936 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 30 Oct 2017 22:04:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>