[Asterisk-code-review] pjsip: Add tests for 'ip' option of 'identify by' on endpoint. (testsuite[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/6908 )

Change subject: pjsip: Add tests for 'ip' option of 'identify_by' on endpoint.
......................................................................


Patch Set 3:

(6 comments)

https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/configs/ast1/extensions.conf
File tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/configs/ast1/extensions.conf:

https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/configs/ast1/extensions.conf@2
PS3, Line 2: exten => echo,1,Answer()
           : same  =>      n,Echo()
           : same  =>      n,Hangup()
Leftovers?


https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/configs/ast1/extensions.conf@10
PS3, Line 10: exten => early,1,Progress()
            : same  =>       n,Playback(hello-world,noanswer)
            : same  =>       n,Hangup(INTERWORKING)
            : 
            : ;This dialstring can be altered once endpoints can be used directly
            : exten => bob,1,Dial(PJSIP/sip:bob at 127.0.0.1:5062)
            : same  =>     n,Hangup()
Same


https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/test-config.yaml
File tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/test-config.yaml:

https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/test-config.yaml@18
PS3, Line 18: '-s': 'alice-ipv4-udp'
Don't need this since you're not referencing [service] in teh xml.


https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/test-config.yaml@22
PS3, Line 22: '-s': 'alice-ipv6-udp'
Same


https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/extensions.conf
File tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/extensions.conf:

https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/extensions.conf@2
PS3, Line 2: xten => echo,1,Answer()
           : same  =>      n,Echo()
           : same  =>      n,Hangup()
Leftovers?


https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/extensions.conf@10
PS3, Line 10: exten => early,1,Progress()
            : same  =>       n,Playback(hello-world,noanswer)
            : same  =>       n,Hangup(INTERWORKING)
            : 
            : ;This dialstring can be altered once endpoints can be used directly
            : exten => bob,1,Dial(PJSIP/sip:bob at 127.0.0.1:5062)
            : same  =>     n,Hangup()
Same



-- 
To view, visit https://gerrit.asterisk.org/6908
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4e504b0063c723f6cdafd0f78281e33027f7ac
Gerrit-Change-Number: 6908
Gerrit-PatchSet: 3
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Thu, 26 Oct 2017 12:13:33 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171026/093bf973/attachment-0001.html>