<p>George Joseph <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6908">View Change</a></p><p>Patch set 3:</p><p>(6 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/configs/ast1/extensions.conf">File tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/configs/ast1/extensions.conf:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/configs/ast1/extensions.conf@2">Patch Set #3, Line 2:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">exten => echo,1,Answer()<br>same => n,Echo()<br>same => n,Hangup()<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Leftovers?</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/configs/ast1/extensions.conf@10">Patch Set #3, Line 10:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">exten => early,1,Progress()<br>same => n,Playback(hello-world,noanswer)<br>same => n,Hangup(INTERWORKING)<br><br>;This dialstring can be altered once endpoints can be used directly<br>exten => bob,1,Dial(PJSIP/sip:bob@127.0.0.1:5062)<br>same => n,Hangup()<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/test-config.yaml">File tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/test-config.yaml@18">Patch Set #3, Line 18:</a> <code style="font-family:monospace,monospace">'-s': 'alice-ipv4-udp'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Don't need this since you're not referencing [service] in teh xml.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host_only/test-config.yaml@22">Patch Set #3, Line 22:</a> <code style="font-family:monospace,monospace">'-s': 'alice-ipv6-udp'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/extensions.conf">File tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/extensions.conf:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/extensions.conf@2">Patch Set #3, Line 2:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">xten => echo,1,Answer()<br>same => n,Echo()<br>same => n,Hangup()<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Leftovers?</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6908/3/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_user_only/configs/ast1/extensions.conf@10">Patch Set #3, Line 10:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">exten => early,1,Progress()<br>same => n,Playback(hello-world,noanswer)<br>same => n,Hangup(INTERWORKING)<br><br>;This dialstring can be altered once endpoints can be used directly<br>exten => bob,1,Dial(PJSIP/sip:bob@127.0.0.1:5062)<br>same => n,Hangup()<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6908">change 6908</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6908"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ieb4e504b0063c723f6cdafd0f78281e33027f7ac </div>
<div style="display:none"> Gerrit-Change-Number: 6908 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 26 Oct 2017 12:13:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>