[Asterisk-code-review] This patch adds a beanstalk CEL backend. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/6841 )

Change subject: This patch adds a beanstalk CEL backend.
......................................................................


Patch Set 3:

(4 comments)

Couple minor findings before I can +1.

https://gerrit.asterisk.org/#/c/6841/3/cel/cel_beanstalkd.c
File cel/cel_beanstalkd.c:

https://gerrit.asterisk.org/#/c/6841/3/cel/cel_beanstalkd.c@180
PS3, Line 180: 		//enablecel = 0;
No commenting out code, just delete the line.


https://gerrit.asterisk.org/#/c/6841/3/cel/cel_beanstalkd.c@184
PS3, Line 184: 		//enablecel = 0;
Instead of commenting out please set enablecel=0 after unregistering the backend (same as your cdr module).


https://gerrit.asterisk.org/#/c/6841/3/configs/samples/cel.conf.sample
File configs/samples/cel.conf.sample:

https://gerrit.asterisk.org/#/c/6841/3/configs/samples/cel.conf.sample@116
PS3, Line 116: ;
Nit: can you revert the change to this file?  It is enough to trigger package managers to see this config as updated.  RPM for example will create cel.conf.rpmnew.


https://gerrit.asterisk.org/#/c/6841/3/configs/samples/cel_beanstalkd.conf.sample
File configs/samples/cel_beanstalkd.conf.sample:

https://gerrit.asterisk.org/#/c/6841/3/configs/samples/cel_beanstalkd.conf.sample@8
PS3, Line 8: ; Use the 'enable' keyword to turn CEL logging
It's 'enabled', not 'enable'.



-- 
To view, visit https://gerrit.asterisk.org/6841
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3a087faeeac045d69a2a018e60e29831ddb95ab
Gerrit-Change-Number: 6841
Gerrit-PatchSet: 3
Gerrit-Owner: Nir Simionovich (GreenfieldTech - Israel) <nirs at greenfieldtech.net>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 24 Oct 2017 15:52:29 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171024/60906e05/attachment.html>