<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6841">View Change</a></p><p>Patch set 3:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Couple minor findings before I can +1.</p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6841/3/cel/cel_beanstalkd.c">File cel/cel_beanstalkd.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6841/3/cel/cel_beanstalkd.c@180">Patch Set #3, Line 180:</a> <code style="font-family:monospace,monospace">           //enablecel = 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">No commenting out code, just delete the line.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6841/3/cel/cel_beanstalkd.c@184">Patch Set #3, Line 184:</a> <code style="font-family:monospace,monospace">           //enablecel = 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Instead of commenting out please set enablecel=0 after unregistering the backend (same as your cdr module).</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6841/3/configs/samples/cel.conf.sample">File configs/samples/cel.conf.sample:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6841/3/configs/samples/cel.conf.sample@116">Patch Set #3, Line 116:</a> <code style="font-family:monospace,monospace">;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Nit: can you revert the change to this file?  It is enough to trigger package managers to see this config as updated.  RPM for example will create cel.conf.rpmnew.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6841/3/configs/samples/cel_beanstalkd.conf.sample">File configs/samples/cel_beanstalkd.conf.sample:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6841/3/configs/samples/cel_beanstalkd.conf.sample@8">Patch Set #3, Line 8:</a> <code style="font-family:monospace,monospace">; Use the 'enable' keyword to turn CEL logging</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">It's 'enabled', not 'enable'.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6841">change 6841</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6841"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic3a087faeeac045d69a2a018e60e29831ddb95ab </div>
<div style="display:none"> Gerrit-Change-Number: 6841 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Nir Simionovich (GreenfieldTech - Israel) <nirs@greenfieldtech.net> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 24 Oct 2017 15:52:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>