[Asterisk-code-review] pjproject bundled: Disable TCP/TLS keep-alives. (asterisk[13])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/6807 )

Change subject: pjproject_bundled: Disable TCP/TLS keep-alives.
......................................................................


Patch Set 1:

I have the time. I simply do not do it. My bug fix changes the behavior of those who *have not* cared about keep_alive_interval. Otherwise they would have seen this bug, this second keep-alive coming from somewhere, before and reported it. Joshua’s proposal changes the behavior for those who *have* changed keep_alive_interval. In both alternatives, there are corner cases, which *could* be serious ripple-effects for others. In both alternatives. I am not convinced that one is better than the other. I am even convinced that there are no ripple-effects with my proposal.

Furthermore, default values should be good, reasonable defaults and I do not think a keep_alive_interval from a UAS is a good behavior. It is such an unexpected behavior, that one of my devices crashes. Therefore Joshua’s proposal is not a good default. Finally, I do not benefit from this change, I even face drawbacks if I go for Joshua’s proposal. My patch works for me. Therefore, there is no motivation to go for this.


-- 
To view, visit https://gerrit.asterisk.org/6807
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I27c7a87c882b02f56ff3b739630d9b9e5912cc68
Gerrit-Change-Number: 6807
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 19 Oct 2017 11:07:24 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171019/9ca5c7eb/attachment.html>