[Asterisk-code-review] pjproject bundled: Disable TCP/TLS keep-alives. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6807 )

Change subject: pjproject_bundled: Disable TCP/TLS keep-alives.
......................................................................


Patch Set 1:

The option and functionality is not granular enough to distinguish between UAC and UAS. My fear is that by changing this option in PJSIP we alter existing behavior that has existed for quite awhile, and while it makes it match chan_sip behavior and fix your scenario it then potentially causes problems for others who may have been unknowingly relying on it.


-- 
To view, visit https://gerrit.asterisk.org/6807
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I27c7a87c882b02f56ff3b739630d9b9e5912cc68
Gerrit-Change-Number: 6807
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 16 Oct 2017 11:42:11 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171016/3a4e3e63/attachment.html>