[Asterisk-code-review] pjproject bundled: Disable TCP/TLS keep-alives. (asterisk[13])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/6807 )

Change subject: pjproject_bundled: Disable TCP/TLS keep-alives.
......................................................................


Patch Set 1:

I do not need this and I do not think this is good behavior of an UAS. For me, keep-alive kills TCP/TLS connections. A default should not crash a remote phone. Some platforms like Apple iOS might even close such chatty connections. I would have to double-check that. This is not something an UAS should do because the UAS is behind a NAT normally. Finally, chan_sip did not do that either on default.

This might be interesting for Asterisk as UAC. However, if I am not mistaken even that runtime-setting introduced with Asterisk 13.2.0 is not that fine grained – it is for all connections, isn’t it? There is no way to limit this to IPv4/UAS in general or a specific endpoint, or? The original commit message of that change in Asterisk 13.2.0 mentioned something like 33 (!) seconds for UACs. I was not able to find something like that in the source code of the PJProject, yet. Somebody else should investigate that, if you really want it to match the previous chan_pjsip behavior. Again, chan_sip does not do this on default either.

I do not use CRLN based keep-alives for any TCP/TLS connections. If you want it, please, hijack this change, go for DEFAULT_KEEPALIVE_INTERVAL = 90, and change sip_to_pjsip.py. I went for matching the default behavior of chan_sip.


-- 
To view, visit https://gerrit.asterisk.org/6807
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I27c7a87c882b02f56ff3b739630d9b9e5912cc68
Gerrit-Change-Number: 6807
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 16 Oct 2017 11:37:44 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171016/4fad7e7c/attachment.html>