[Asterisk-code-review] ari/bridge: Add mute, dtmf suppression controls (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6675 )

Change subject: ari/bridge: Add mute, dtmf suppression controls
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/6675/3/include/asterisk/stasis_app.h
File include/asterisk/stasis_app.h:

https://gerrit.asterisk.org/#/c/6675/3/include/asterisk/stasis_app.h@822
PS3, Line 822:  * \param absorb Whether audio should be muted (1) instead of passed through (0).
This documentation is incorrect, as you named it mute instead of absorb here.


https://gerrit.asterisk.org/#/c/6675/3/res/stasis/control.c
File res/stasis/control.c:

https://gerrit.asterisk.org/#/c/6675/3/res/stasis/control.c@137
PS3, Line 137: 	control->bridge_features = NULL;
ao2_alloc uses calloc underneath, so this is NULL anyway


https://gerrit.asterisk.org/#/c/6675/3/rest-api/api-docs/bridges.json
File rest-api/api-docs/bridges.json:

https://gerrit.asterisk.org/#/c/6675/3/rest-api/api-docs/bridges.json@180
PS3, Line 180:                      "defaultValue": false
These don't seem to be indented properly.



-- 
To view, visit https://gerrit.asterisk.org/6675
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4002adfb65c9a8027ee9e1a5f477e0f01cf9d61
Gerrit-Change-Number: 6675
Gerrit-PatchSet: 3
Gerrit-Owner: Seán C. McCord <ulexus at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Seán C. McCord <ulexus at gmail.com>
Gerrit-Comment-Date: Tue, 10 Oct 2017 10:37:56 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171010/04ce4b70/attachment.html>