<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6675">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6675/3/include/asterisk/stasis_app.h">File include/asterisk/stasis_app.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6675/3/include/asterisk/stasis_app.h@822">Patch Set #3, Line 822:</a> <code style="font-family:monospace,monospace"> * \param absorb Whether audio should be muted (1) instead of passed through (0).</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This documentation is incorrect, as you named it mute instead of absorb here.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6675/3/res/stasis/control.c">File res/stasis/control.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6675/3/res/stasis/control.c@137">Patch Set #3, Line 137:</a> <code style="font-family:monospace,monospace">   control->bridge_features = NULL;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ao2_alloc uses calloc underneath, so this is NULL anyway</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/6675/3/rest-api/api-docs/bridges.json">File rest-api/api-docs/bridges.json:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6675/3/rest-api/api-docs/bridges.json@180">Patch Set #3, Line 180:</a> <code style="font-family:monospace,monospace">                     "defaultValue": false</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">These don't seem to be indented properly.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6675">change 6675</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6675"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id4002adfb65c9a8027ee9e1a5f477e0f01cf9d61 </div>
<div style="display:none"> Gerrit-Change-Number: 6675 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Seán C. McCord <ulexus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Seán C. McCord <ulexus@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 10 Oct 2017 10:37:56 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>