[Asterisk-code-review] bridge basic: Display failed target (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7392 )

Change subject: bridge_basic: Display failed target
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/7392/1/main/bridge_basic.c
File main/bridge_basic.c:

https://gerrit.asterisk.org/#/c/7392/1/main/bridge_basic.c@3352
PS1, Line 3352: 		ast_log(LOG_WARNING, "Unable to acquire target extension for attended transfer: '%s@%s'\n", exten, props->context);
> grab_transfer() does add numbers to the exten buffer.  Its purpose is to co
Actually, what would be more useful for warning message here than adding an undefined exten at context would be to add the ast_channel_name(bridge_channel->chan)) to the warning message.  That way you would know the transferrer channel that didn't complete the attended transfer.



-- 
To view, visit https://gerrit.asterisk.org/7392
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Idac66b7628c99379cc9269158377fd87dc97a880
Gerrit-Change-Number: 7392
Gerrit-PatchSet: 1
Gerrit-Owner: Niklas Larsson <niklas at tese.se>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Niklas Larsson <niklas at tese.se>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 29 Nov 2017 17:49:09 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171129/0799fcb8/attachment.html>