[Asterisk-code-review] bridge basic: Display failed target (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7392 )

Change subject: bridge_basic: Display failed target
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/7392/1/main/bridge_basic.c
File main/bridge_basic.c:

https://gerrit.asterisk.org/#/c/7392/1/main/bridge_basic.c@3352
PS1, Line 3352: 		ast_log(LOG_WARNING, "Unable to acquire target extension for attended transfer: '%s@%s'\n", exten, props->context);
> I get: 
grab_transfer() does add numbers to the exten buffer.  Its purpose is to collect digits to a valid exten for transfer after all.  You do not know why grab_transfer() returned failure.  However, the most likely reason there would be something in the buffer on failure is if the caller hungup after dialing a few digits that didn't match an exten in the context.  It is better to promote the debug messages in grab_transfer() to ast_verb().  For the hangup/error case returned by ast_app_dtget() in grab_transfer() you can add another appropriate ast_verb() message.

grab_transfer() can return error with an empty exten buffer if the user ran out of the configured attempts to enter a number.  That does not mean the user failed to enter digits.

Making the change in grab_transfer() allows blind transfers to benefit as well.



-- 
To view, visit https://gerrit.asterisk.org/7392
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Idac66b7628c99379cc9269158377fd87dc97a880
Gerrit-Change-Number: 7392
Gerrit-PatchSet: 1
Gerrit-Owner: Niklas Larsson <niklas at tese.se>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Niklas Larsson <niklas at tese.se>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 29 Nov 2017 17:40:14 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171129/74dbe0f8/attachment.html>