[Asterisk-code-review] chan sip: ICE server-reflexive candidates (srflx) with Dual-... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7331 )

Change subject: chan_sip: ICE server-reflexive candidates (srflx) with Dual-Stack.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Minor commit message wording.

https://gerrit.asterisk.org/#/c/7331/1//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/7331/1//COMMIT_MSG@7
PS1, Line 7: chan_sip: ICE server-reflexive candidates (srflx) with Dual-Stack.
res_rtp_asterisk:

The change is not specific to chan_sip.  It is in the RTP layer which is common to any module that uses RTP/ICE such as chan_sip and chan_pjsip.


https://gerrit.asterisk.org/#/c/7331/1//COMMIT_MSG@10
PS1, Line 10: srflx are gathered and send via SDP, even when Asterisk was enabled for
s/are/is/
s/send/sent/
s/was/is/



-- 
To view, visit https://gerrit.asterisk.org/7331
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07d8e2bfa7b6fe06fcdc73d390a7a9a4d8c0bc1
Gerrit-Change-Number: 7331
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 21 Nov 2017 22:40:25 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171121/11356537/attachment.html>