[Asterisk-code-review] chan sip: ICE server-reflexive candidates (srflx) with Dual-... (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/7331 )

Change subject: chan_sip: ICE server-reflexive candidates (srflx) with Dual-Stack.
......................................................................


Patch Set 1:

The change looks more complicated then it was. All I did was adding "ast_sockaddr_is_any". Secondly, I added a loop to find the first IPv4 instead of going for the first/any IP address as originating address of the STUN request. Finally, I had to move the rest of the code up one tab.

Consequently, I added just one additional condition to enter that section and I added a simple loop.


-- 
To view, visit https://gerrit.asterisk.org/7331
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07d8e2bfa7b6fe06fcdc73d390a7a9a4d8c0bc1
Gerrit-Change-Number: 7331
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Tue, 21 Nov 2017 17:53:30 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171121/dc67b46f/attachment-0001.html>