[Asterisk-code-review] core: Add cache media frames debugging option. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7197 )

Change subject: core: Add cache_media_frames debugging option.
......................................................................


Patch Set 1:

> (3 comments)
 > 
 > Feel free to ignore my earlier comment about not using LOW_MEMORY,
 > but I'd like if we didn't hit threadstorage when frame caching is
 > disabled.

I would prefer not to.  The option is intended for debugging only and should RARELY be disabled.  The unnecessary threadstorage allocation when disabled can be ignored.

As an added benefit for how it is now, we could add a CLI command to disable the cache at run time.  When disabled the cache could then empty as nothing will add entries to the cache.


-- 
To view, visit https://gerrit.asterisk.org/7197
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ab2ce0f4547cccf2eb214901835c2d951b78c00
Gerrit-Change-Number: 7197
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 13 Nov 2017 17:33:18 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171113/56f76e8b/attachment.html>