[Asterisk-code-review] core: Add cache media frames debugging option. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7197 )

Change subject: core: Add cache_media_frames debugging option.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Feel free to ignore my earlier comment about not using LOW_MEMORY, but I'd like if we didn't hit threadstorage when frame caching is disabled.

https://gerrit.asterisk.org/#/c/7197/1/channels/iax2/parser.c
File channels/iax2/parser.c:

https://gerrit.asterisk.org/#/c/7197/1/channels/iax2/parser.c@1219
PS1, Line 1219: 	if (cacheable) {
Can you add a check for ast_opt_cache_media_frames to avoid threadstorage when it's disabled?


https://gerrit.asterisk.org/#/c/7197/1/main/frame.c
File main/frame.c:

https://gerrit.asterisk.org/#/c/7197/1/main/frame.c@82
PS1, Line 82: 	if ((frames = ast_threadstorage_get(&frame_cache, sizeof(*frames)))) {
Check for ast_opt_cache_media_frames here as well?


https://gerrit.asterisk.org/#/c/7197/1/main/frame.c@319
PS1, Line 319: 	if ((frames = ast_threadstorage_get(&frame_cache, sizeof(*frames)))) {
Here as well.



-- 
To view, visit https://gerrit.asterisk.org/7197
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ab2ce0f4547cccf2eb214901835c2d951b78c00
Gerrit-Change-Number: 7197
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 13 Nov 2017 17:11:51 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171113/95fd8f9a/attachment.html>