[Asterisk-code-review] pjsip/verify bodies: Update based on changes to presence URI. (testsuite[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7143 )

Change subject: pjsip/verify_bodies: Update based on changes to presence URI.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

My comment in the source was written before I read comments on ASTERISK-27290. I think the correct solution is to make this test expect the quoted name to be absent from the Contact header (unconditionally).  I'd be fine with setting the minimum version so this is skipped on broken versions of Asterisk.  The testsuite should not say that something works correctly when it doesn't.

https://gerrit.asterisk.org/#/c/7143/1/tests/channels/pjsip/subscriptions/presence/verify_bodies/verify_pidf/test-config.yaml
File tests/channels/pjsip/subscriptions/presence/verify_bodies/verify_pidf/test-config.yaml:

https://gerrit.asterisk.org/#/c/7143/1/tests/channels/pjsip/subscriptions/presence/verify_bodies/verify_pidf/test-config.yaml@139
PS1, Line 139:                 contact: '^"alice" <sip:alice at 127.0.0.1(:5060)?>$'
Why not do:
'^("alice" )?<sip:alice at 127.0.0.1(:5060)?>$'

This would avoid duplicating the config for this little difference.  I don't have yappcap so I couldn't test but this should work.



-- 
To view, visit https://gerrit.asterisk.org/7143
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03e432b3e524791da26a41698bb5eabb619274a6
Gerrit-Change-Number: 7143
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 10 Nov 2017 20:37:34 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171110/ed2d2e23/attachment.html>