<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7143">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">My comment in the source was written before I read comments on ASTERISK-27290. I think the correct solution is to make this test expect the quoted name to be absent from the Contact header (unconditionally).  I'd be fine with setting the minimum version so this is skipped on broken versions of Asterisk.  The testsuite should not say that something works correctly when it doesn't.</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7143/1/tests/channels/pjsip/subscriptions/presence/verify_bodies/verify_pidf/test-config.yaml">File tests/channels/pjsip/subscriptions/presence/verify_bodies/verify_pidf/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7143/1/tests/channels/pjsip/subscriptions/presence/verify_bodies/verify_pidf/test-config.yaml@139">Patch Set #1, Line 139:</a> <code style="font-family:monospace,monospace">                contact: '^"alice" <sip:alice@127.0.0.1(:5060)?>$'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why not do:<br>'^("alice" )?<sip:alice@127.0.0.1(:5060)?>$'</p><p style="white-space: pre-wrap; word-wrap: break-word;">This would avoid duplicating the config for this little difference.  I don't have yappcap so I couldn't test but this should work.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7143">change 7143</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7143"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I03e432b3e524791da26a41698bb5eabb619274a6 </div>
<div style="display:none"> Gerrit-Change-Number: 7143 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 10 Nov 2017 20:37:34 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>