[Asterisk-code-review] bridge softmix: Fix leak on ast stream topology set stream f... (asterisk[15])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7106 )

Change subject: bridge_softmix: Fix leak on ast_stream_topology_set_stream failure.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/7106/1/bridges/bridge_softmix.c
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/#/c/7106/1/bridges/bridge_softmix.c@544
PS1, Line 544: 				if (ast_stream_topology_set_stream(dest, dest_index - 1, clone)) {
> This should never fail here because we are always replacing an existing str
I see now that dest_index - 1 is always less than the count on dest.  I'm thinking we shouldn't check at all, I'll add a comment that this cannot fail?



-- 
To view, visit https://gerrit.asterisk.org/7106
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d25704859efbe50b8b82cfe1cd3c40ba177c9f
Gerrit-Change-Number: 7106
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 08 Nov 2017 03:15:15 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171107/f69486e6/attachment-0001.html>