<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7106">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7106/1/bridges/bridge_softmix.c">File bridges/bridge_softmix.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7106/1/bridges/bridge_softmix.c@544">Patch Set #1, Line 544:</a> <code style="font-family:monospace,monospace">                         if (ast_stream_topology_set_stream(dest, dest_index - 1, clone)) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This should never fail here because we are always replacing an existing str</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I see now that dest_index - 1 is always less than the count on dest.  I'm thinking we shouldn't check at all, I'll add a comment that this cannot fail?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7106">change 7106</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7106"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I91d25704859efbe50b8b82cfe1cd3c40ba177c9f </div>
<div style="display:none"> Gerrit-Change-Number: 7106 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 08 Nov 2017 03:15:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>