[Asterisk-code-review] res pjsip history: Fix multiple leaks on vector append failure. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/7086 )

Change subject: res_pjsip_history: Fix multiple leaks on vector append failure.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/7086/1/res/res_pjsip_history.c
File res/res_pjsip_history.c:

https://gerrit.asterisk.org/#/c/7086/1/res/res_pjsip_history.c@968
PS1, Line 968: 			/* BUGBUG: possible leak on failure? */
> This spot I was not sure what to do.  It seems like we leak here but I'm un
Seems like to me you'd just want to goto error. Firstly, if it can't append that means the vector couldn't make room, so there are bigger problems going on. Secondly, if the system could continue on it seems like missing the append here would throw off the expression evaluation.



-- 
To view, visit https://gerrit.asterisk.org/7086
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e8d5183ace284095cc721f3b1fb32ade3f940f
Gerrit-Change-Number: 7086
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 07 Nov 2017 15:45:19 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171107/85f1afd2/attachment.html>