<p>Kevin Harwell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/7086">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/7086/1/res/res_pjsip_history.c">File res/res_pjsip_history.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/7086/1/res/res_pjsip_history.c@968">Patch Set #1, Line 968:</a> <code style="font-family:monospace,monospace">                    /* BUGBUG: possible leak on failure? */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This spot I was not sure what to do.  It seems like we leak here but I'm un</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Seems like to me you'd just want to goto error. Firstly, if it can't append that means the vector couldn't make room, so there are bigger problems going on. Secondly, if the system could continue on it seems like missing the append here would throw off the expression evaluation.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/7086">change 7086</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/7086"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I41e8d5183ace284095cc721f3b1fb32ade3f940f </div>
<div style="display:none"> Gerrit-Change-Number: 7086 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 07 Nov 2017 15:45:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>