[Asterisk-code-review] res rtp asterisk: Pausing RTP and clearing remote address ca... (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/5564 )

Change subject: res_rtp_asterisk: Pausing RTP and clearing remote address causes RTCP failures
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/5564/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 5725
> Did you mean to remove the rtp instance's remote address as well as rtcp->t
Yes. rtcp->them should not be set to NULL (that's what was causing the problem). Setting the remote address also sets this value to the given "addr", which in this case is NULL. So  really the second setting of rtcp->them was redundant here.


-- 
To view, visit https://gerrit.asterisk.org/5564
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6be200fb20db647e48b5138ea4b81dfa7962974b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes