[Asterisk-code-review] res rtp asterisk: Pausing RTP and clearing remote address ca... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/5564 )

Change subject: res_rtp_asterisk: Pausing RTP and clearing remote address causes RTCP failures
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5564/1//COMMIT_MSG
Commit Message:

Line 9: When a call gets put on hold RTP is temporarily stopped and Asterisk was setting
I'm a little confused about whether you're talking about the rtp instance's remote address or rtcp->them.  The patch removes the setting of both the rtp instance remote address and rtcp->them but below when you talk about the existing check, that check was only for rtcp->them.


https://gerrit.asterisk.org/#/c/5564/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 5725
Did you mean to remove the rtp instance's remote address as well as rtcp->them?


-- 
To view, visit https://gerrit.asterisk.org/5564
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6be200fb20db647e48b5138ea4b81dfa7962974b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes