[Asterisk-code-review] Add rtcp-mux support (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5138 )

Change subject: Add rtcp-mux support
......................................................................


Patch Set 1: -Code-Review

(1 comment)

https://gerrit.asterisk.org/#/c/5138/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

PS1, Line 5053: 				if ((rtp->rtcp->s =
              : 				     create_new_socket("RTCP",
              : 						       ast_sockaddr_is_ipv4(&rtp->rtcp->us) ?
              : 						       AF_INET :
              : 						       ast_sockaddr_is_ipv6(&rtp->rtcp->us) ?
              : 						       AF_INET6 : -1)) < 0) {
> I like the idea, but I'd prefer that (as well as the change to the rtcpdata
> I like the idea, but I'd prefer that (as well as the change to the
 > rtcpdata declaration in ast_rtcp_read()) be changed in a separate
 > review since this doesn't have anything to do with adding the
 > rtcp-mux feature.

You're right. I missed that it was code that was already there.


-- 
To view, visit https://gerrit.asterisk.org/5138
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If46a93ba1282418d2803e3fd7869374da8b77ab5
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes