[Asterisk-code-review] Add rtcp-mux support (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/5138 )

Change subject: Add rtcp-mux support
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/5138/1/include/asterisk/res_pjsip_session.h
File include/asterisk/res_pjsip_session.h:

PS1, Line 86: 	/*! \brief Does remote support rtcp_mux */
            : 	unsigned int remote_rtcp_mux:1;
> > Are you thinking this adds an unsigned int to the struct?
I was relying on the compiler to behave the way Richard was saying. Typically struct fields are aligned on word boundaries. So with the existing bit field, there's a "hole" in the struct between "held" and "stream_type". This hole can be safely filled without affecting the size of the stream or the offsets of the existing fields.


https://gerrit.asterisk.org/#/c/5138/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

PS1, Line 5053: 				if ((rtp->rtcp->s =
              : 				     create_new_socket("RTCP",
              : 						       ast_sockaddr_is_ipv4(&rtp->rtcp->us) ?
              : 						       AF_INET :
              : 						       ast_sockaddr_is_ipv6(&rtp->rtcp->us) ?
              : 						       AF_INET6 : -1)) < 0) {
> Assign and then check. And maybe pull the ternaries out into a temporary?
I like the idea, but I'd prefer that (as well as the change to the rtcpdata declaration in ast_rtcp_read()) be changed in a separate review since this doesn't have anything to do with adding the rtcp-mux feature.


-- 
To view, visit https://gerrit.asterisk.org/5138
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If46a93ba1282418d2803e3fd7869374da8b77ab5
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes