[Asterisk-code-review] Add rtcp-mux support (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5138 )

Change subject: Add rtcp-mux support
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/5138/1/include/asterisk/res_pjsip_session.h
File include/asterisk/res_pjsip_session.h:

PS1, Line 86: 	/*! \brief Does remote support rtcp_mux */
            : 	unsigned int remote_rtcp_mux:1;
> This breaks ABI. I'm not sure that matters, just pointing it out.
Are you thinking this adds an unsigned int to the struct?  This is assigning a bit from an unsigned int that already exists so it doesn't break ABI.  The held and remote_rtcp_mux are co-located in the same unsigned int.


-- 
To view, visit https://gerrit.asterisk.org/5138
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If46a93ba1282418d2803e3fd7869374da8b77ab5
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes