[Asterisk-code-review] Add rtcp-mux support (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5138 )

Change subject: Add rtcp-mux support
......................................................................


Patch Set 1:

(5 comments)

A couple minor things that I saw when looking around. Nothing that appeared to be a bug.

https://gerrit.asterisk.org/#/c/5138/1/include/asterisk/res_pjsip_session.h
File include/asterisk/res_pjsip_session.h:

PS1, Line 86: 	/*! \brief Does remote support rtcp_mux */
            : 	unsigned int remote_rtcp_mux:1;
This breaks ABI. I'm not sure that matters, just pointing it out.


https://gerrit.asterisk.org/#/c/5138/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 334: 	int ice_num_components; /*!< The number of ICE components */
If this should never be negative, use unsigned. Is it possible to have 2³² ICE components?


PS1, Line 4390: rtcpdata + AST_FRIENDLY_OFFSET
We do this 3 times in this function, maybe use a temporary?


Line 4572: 	unsigned char rtpdata[sizeof(rtp->rawdata)];
This makes me uncomfortable (for no reason, I know). In ast_rtcp_read() we're using:

unsigned char rtcpdata[8192 + AST_FRIENDLY_OFFSET];

I feel like we should be consistent one way or the other.


PS1, Line 5053: 				if ((rtp->rtcp->s =
              : 				     create_new_socket("RTCP",
              : 						       ast_sockaddr_is_ipv4(&rtp->rtcp->us) ?
              : 						       AF_INET :
              : 						       ast_sockaddr_is_ipv6(&rtp->rtcp->us) ?
              : 						       AF_INET6 : -1)) < 0) {
Assign and then check. And maybe pull the ternaries out into a temporary?


-- 
To view, visit https://gerrit.asterisk.org/5138
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If46a93ba1282418d2803e3fd7869374da8b77ab5
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes