[Asterisk-code-review] res rtp asterisk: add control frame for when dtls is establi... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5934 )

Change subject: res_rtp_asterisk: add control frame for when dtls is established
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I don't think this needs to be a new control frame and I think exposing the fact that DTLS has been established doesn't really need to be exposed to the core. If we were to add one then one to indicate that media can flow would be better. Any reason we can't use SRCUPDATE or SRCCHANGE, though?

https://gerrit.asterisk.org/#/c/5934/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/5934/1/res/res_rtp_asterisk.c@4760
PS1, Line 4760: 			struct ast_frame dtls_established = {
              : 				AST_FRAME_CONTROL,
              : 				.subclass.integer = AST_CONTROL_DTLS_ESTABLISHED,
              : 			};
              : 			return ast_frisolate(&dtls_established);
Any reason you didn't just use the frame in the RTP struct?



-- 
To view, visit https://gerrit.asterisk.org/5934
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I27ff344f5a8c691a1890dfe3254a4b1a49e7f4a0
Gerrit-Change-Number: 5934
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 29 Jun 2017 20:14:09 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170629/eddf3ada/attachment.html>