<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5934">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think this needs to be a new control frame and I think exposing the fact that DTLS has been established doesn't really need to be exposed to the core. If we were to add one then one to indicate that media can flow would be better. Any reason we can't use SRCUPDATE or SRCCHANGE, though?</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5934/1/res/res_rtp_asterisk.c">File res/res_rtp_asterisk.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5934/1/res/res_rtp_asterisk.c@4760">Patch Set #1, Line 4760:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                  struct ast_frame dtls_established = {<br>                         AST_FRAME_CONTROL,<br>                            .subclass.integer = AST_CONTROL_DTLS_ESTABLISHED,<br>                     };<br>                    return ast_frisolate(&dtls_established);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Any reason you didn't just use the frame in the RTP struct?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5934">change 5934</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5934"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I27ff344f5a8c691a1890dfe3254a4b1a49e7f4a0 </div>
<div style="display:none"> Gerrit-Change-Number: 5934 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 29 Jun 2017 20:14:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>