[Asterisk-code-review] chan pjsip: add a new function PJSIPDtmfMode() (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/5909 )

Change subject: chan_pjsip: add a new function PJSIPDtmfMode()
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5909/3/channels/chan_pjsip.c
File channels/chan_pjsip.c:

https://gerrit.asterisk.org/#/c/5909/3/channels/chan_pjsip.c@2642
PS3, Line 2642: PJSIPDtmfMode
Should the function name match the other PJSIP function's names?
Such as PJSIP_DTMF_MODE.


https://gerrit.asterisk.org/#/c/5909/3/channels/chan_pjsip.c@2828
PS3, Line 2828: ast_register_application_xml
I think the function should be registered as a custom function.

if (ast_custom_function_register(&dtmf_mode_function)) {
	ast_log(LOG_WARNING, "Unable to register PJSIP_DTMF_MODE dialplan function\n");
	goto end;
}

As we change the DTMF mode per session we should have a possibility to get the current session mode.

static struct ast_custom_function dtmf_mode_function = {
        .name = "PJSIP_DTMF_MODE",
        .read = pjsip_acf_dtmf_mode_read,
        .write = pjsip_acf_dtmf_mode_write
};



-- 
To view, visit https://gerrit.asterisk.org/5909
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I20eef5da3e5d1d3e58b304416bc79683f87e7612
Gerrit-Change-Number: 5909
Gerrit-PatchSet: 3
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 27 Jun 2017 14:38:44 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170627/e8d65d6d/attachment.html>