<p>Alexei Gradinari <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5909">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5909/3/channels/chan_pjsip.c">File channels/chan_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5909/3/channels/chan_pjsip.c@2642">Patch Set #3, Line 2642:</a> <code style="font-family:monospace,monospace">PJSIPDtmfMode</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should the function name match the other PJSIP function's names?<br>Such as PJSIP_DTMF_MODE.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5909/3/channels/chan_pjsip.c@2828">Patch Set #3, Line 2828:</a> <code style="font-family:monospace,monospace">ast_register_application_xml</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think the function should be registered as a custom function.</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">if (ast_custom_function_register(&dtmf_mode_function)) {<br>  ast_log(LOG_WARNING, "Unable to register PJSIP_DTMF_MODE dialplan function\n");<br>     goto end;<br>}</pre><p style="white-space: pre-wrap; word-wrap: break-word;">As we change the DTMF mode per session we should have a possibility to get the current session mode.</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">static struct ast_custom_function dtmf_mode_function = {<br>        .name = "PJSIP_DTMF_MODE",<br>        .read = pjsip_acf_dtmf_mode_read,<br>        .write = pjsip_acf_dtmf_mode_write<br>};</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5909">change 5909</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5909"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I20eef5da3e5d1d3e58b304416bc79683f87e7612 </div>
<div style="display:none"> Gerrit-Change-Number: 5909 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 27 Jun 2017 14:38:44 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>