[Asterisk-code-review] testsuite: add a test for PJSIPDtmfMode (testsuite[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5910 )

Change subject: testsuite: add a test for PJSIPDtmfMode
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/5910/1/tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/run-test
File tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/run-test:

https://gerrit.asterisk.org/#/c/5910/1/tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/run-test@3
PS1, Line 3: Copyright (C) 2010, Digium, Inc.
           : Russell Bryant <russell at digium.com>
           : 
           : This program is free software, distributed under the terms of
           : the GNU General Public License Version 2.
           : '''
Copyright isn't correct.


https://gerrit.asterisk.org/#/c/5910/1/tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/run-test@43
PS1, Line 43:         '-s' : '3228080970',
This isn't in the dialplan so the test gets a 404


https://gerrit.asterisk.org/#/c/5910/1/tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/test-config.yaml
File tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/test-config.yaml:

https://gerrit.asterisk.org/#/c/5910/1/tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/test-config.yaml@7
PS1, Line 7:     minversion: '13'
This will be in the next release.


https://gerrit.asterisk.org/#/c/5910/1/tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/test-config.yaml@11
PS1, Line 11:         - SIP
this is a pjsip test



-- 
To view, visit https://gerrit.asterisk.org/5910
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ae7d73aedc42533512adf7b96ed0eab8e09ad8c
Gerrit-Change-Number: 5910
Gerrit-PatchSet: 1
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 27 Jun 2017 09:23:13 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170627/96d2f53b/attachment-0001.html>