<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5910">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5910/1/tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/run-test">File tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/run-test:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5910/1/tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/run-test@3">Patch Set #1, Line 3:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Copyright (C) 2010, Digium, Inc.<br>Russell Bryant <russell@digium.com><br><br>This program is free software, distributed under the terms of<br>the GNU General Public License Version 2.<br>'''<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Copyright isn't correct.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5910/1/tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/run-test@43">Patch Set #1, Line 43:</a> <code style="font-family:monospace,monospace">        '-s' : '3228080970',</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This isn't in the dialplan so the test gets a 404</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/5910/1/tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/test-config.yaml">File tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5910/1/tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/test-config.yaml@7">Patch Set #1, Line 7:</a> <code style="font-family:monospace,monospace">    minversion: '13'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This will be in the next release.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5910/1/tests/channels/pjsip/dialplan_functions/pjsip_dtmfmode/test-config.yaml@11">Patch Set #1, Line 11:</a> <code style="font-family:monospace,monospace">        - SIP</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">this is a pjsip test</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5910">change 5910</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5910"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8ae7d73aedc42533512adf7b96ed0eab8e09ad8c </div>
<div style="display:none"> Gerrit-Change-Number: 5910 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 27 Jun 2017 09:23:13 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>