[Asterisk-code-review] res/res pjsip t38 add test to verify T.38 gets quickly rejected (testsuite[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5901 )

Change subject: res/res_pjsip_t38 add test to verify T.38 gets quickly rejected
......................................................................


Patch Set 3:

(4 comments)

https://gerrit.asterisk.org/#/c/5901/3/tests/fax/pjsip/t38_fast_reject/configs/ast1/pjsip.conf
File tests/fax/pjsip/t38_fast_reject/configs/ast1/pjsip.conf:

https://gerrit.asterisk.org/#/c/5901/3/tests/fax/pjsip/t38_fast_reject/configs/ast1/pjsip.conf@81
PS3, Line 81: dtls_cert_file = /etc/asterisk/keys/asterisk.crt
            : dtls_private_key = /etc/asterisk/keys/asterisk.key
            : dtls_cipher = ALL
These will cause the test to fail.


https://gerrit.asterisk.org/#/c/5901/3/tests/fax/pjsip/t38_fast_reject/run-test
File tests/fax/pjsip/t38_fast_reject/run-test:

https://gerrit.asterisk.org/#/c/5901/3/tests/fax/pjsip/t38_fast_reject/run-test@3
PS3, Line 3: '''
           : Copyright (C) 2011, Digium, Inc.
           : Matthew Nicholson <mnicholson at digium.com>
           : 
           : This program is free software, distributed under the terms of
           : the GNU General Public License Version 2.
           : '''
This copyright isn't valid for this.


https://gerrit.asterisk.org/#/c/5901/3/tests/fax/pjsip/t38_fast_reject/run-test@52
PS3, Line 52:         '-s' : e164,
e164 isn't defined anywhere as a variable from what I can see


https://gerrit.asterisk.org/#/c/5901/3/tests/fax/pjsip/t38_fast_reject/test-config.yaml
File tests/fax/pjsip/t38_fast_reject/test-config.yaml:

https://gerrit.asterisk.org/#/c/5901/3/tests/fax/pjsip/t38_fast_reject/test-config.yaml@7
PS3, Line 7:     minversion: '1.4'
This isn't correct, it'll be in the next release.



-- 
To view, visit https://gerrit.asterisk.org/5901
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida087c3d410c95c87aeca506c81eabe8bde062ef
Gerrit-Change-Number: 5901
Gerrit-PatchSet: 3
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 27 Jun 2017 09:22:06 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170627/6797e45d/attachment.html>