<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5901">View Change</a></p><p>Patch set 3:</p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5901/3/tests/fax/pjsip/t38_fast_reject/configs/ast1/pjsip.conf">File tests/fax/pjsip/t38_fast_reject/configs/ast1/pjsip.conf:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5901/3/tests/fax/pjsip/t38_fast_reject/configs/ast1/pjsip.conf@81">Patch Set #3, Line 81:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">dtls_cert_file = /etc/asterisk/keys/asterisk.crt<br>dtls_private_key = /etc/asterisk/keys/asterisk.key<br>dtls_cipher = ALL<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">These will cause the test to fail.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/5901/3/tests/fax/pjsip/t38_fast_reject/run-test">File tests/fax/pjsip/t38_fast_reject/run-test:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5901/3/tests/fax/pjsip/t38_fast_reject/run-test@3">Patch Set #3, Line 3:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">'''<br>Copyright (C) 2011, Digium, Inc.<br>Matthew Nicholson <mnicholson@digium.com><br><br>This program is free software, distributed under the terms of<br>the GNU General Public License Version 2.<br>'''<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This copyright isn't valid for this.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5901/3/tests/fax/pjsip/t38_fast_reject/run-test@52">Patch Set #3, Line 52:</a> <code style="font-family:monospace,monospace">        '-s' : e164,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">e164 isn't defined anywhere as a variable from what I can see</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/5901/3/tests/fax/pjsip/t38_fast_reject/test-config.yaml">File tests/fax/pjsip/t38_fast_reject/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5901/3/tests/fax/pjsip/t38_fast_reject/test-config.yaml@7">Patch Set #3, Line 7:</a> <code style="font-family:monospace,monospace">    minversion: '1.4'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This isn't correct, it'll be in the next release.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5901">change 5901</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5901"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ida087c3d410c95c87aeca506c81eabe8bde062ef </div>
<div style="display:none"> Gerrit-Change-Number: 5901 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 27 Jun 2017 09:22:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>