[Asterisk-code-review] chan pjsip: add a new function PJSIPDtmfMode() (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5909 )

Change subject: chan_pjsip: add a new function PJSIPDtmfMode()
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5909/2/channels/chan_pjsip.c
File channels/chan_pjsip.c:

https://gerrit.asterisk.org/#/c/5909/2/channels/chan_pjsip.c@2666
PS2, Line 2666: 		pchannel->session->endpoint->dtmf= AST_SIP_DTMF_INFO;
              : 	} else if (!strcasecmp(mode, "rfc2833")) {
              : 		pchannel->session->endpoint->dtmf= AST_SIP_DTMF_RFC_4733;
              : 	} else if (!strcasecmp(mode, "inband")) {
              : 		pchannel->session->endpoint->dtmf= AST_SIP_DTMF_INBAND;
You can not do this. Endpoint is an immutable shared object. It can not be altered.


https://gerrit.asterisk.org/#/c/5909/2/channels/chan_pjsip.c@2701
PS2, Line 2701: 				ao2_ref(pchannel->session, -1);
Why is this reference count being decreased? Afterwards it will be incorrect.



-- 
To view, visit https://gerrit.asterisk.org/5909
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I20eef5da3e5d1d3e58b304416bc79683f87e7612
Gerrit-Change-Number: 5909
Gerrit-PatchSet: 2
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 26 Jun 2017 13:06:28 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170626/faa8ec07/attachment.html>