<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5909">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5909/2/channels/chan_pjsip.c">File channels/chan_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5909/2/channels/chan_pjsip.c@2666">Patch Set #2, Line 2666:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">         pchannel->session->endpoint->dtmf= AST_SIP_DTMF_INFO;<br>        } else if (!strcasecmp(mode, "rfc2833")) {<br>          pchannel->session->endpoint->dtmf= AST_SIP_DTMF_RFC_4733;<br>    } else if (!strcasecmp(mode, "inband")) {<br>           pchannel->session->endpoint->dtmf= AST_SIP_DTMF_INBAND;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You can not do this. Endpoint is an immutable shared object. It can not be altered.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5909/2/channels/chan_pjsip.c@2701">Patch Set #2, Line 2701:</a> <code style="font-family:monospace,monospace">                              ao2_ref(pchannel->session, -1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why is this reference count being decreased? Afterwards it will be incorrect.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5909">change 5909</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5909"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I20eef5da3e5d1d3e58b304416bc79683f87e7612 </div>
<div style="display:none"> Gerrit-Change-Number: 5909 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 26 Jun 2017 13:06:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>