[Asterisk-code-review] chan pjsip: Add support for multiple streams of the same type. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5876 )

Change subject: chan_pjsip: Add support for multiple streams of the same type.
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.asterisk.org/#/c/5876/11/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/5876/11/res/res_pjsip_session.c@494
PS11, Line 494: 		/* Enforce the user configured maximum stream count for this type by marking it declined and moving on*/
              : 		if (is_stream_limitation_reached(type, session->endpoint, type_streams)) {
              : 			ast_stream_set_state(stream, AST_STREAM_STATE_REMOVED);
              : 			continue;
              : 		}
> Should we check this before everything else? Like right after we retrieve t
In order to decline the stream we need to have a stream, and in order to maintain a bit of sanity in the sessions vector I opted to create a session media for it. That's why it's down here.



-- 
To view, visit https://gerrit.asterisk.org/5876
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8afd8dd2eb538806a39b887af0abd046266e14c7
Gerrit-Change-Number: 5876
Gerrit-PatchSet: 11
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 22 Jun 2017 21:56:58 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170622/1e75428a/attachment.html>