[Asterisk-code-review] chan pjsip: Add support for multiple streams of the same type. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5876 )

Change subject: chan_pjsip: Add support for multiple streams of the same type.
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.asterisk.org/#/c/5876/11/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/5876/11/res/res_pjsip_session.c@3408
PS11, Line 3408: 		if (is_stream_limitation_reached(ast_stream_get_type(stream), session->endpoint, type_streams)) {
               : 			ast_stream_set_state(stream, AST_STREAM_STATE_REMOVED);
               : 		}
> My only thought to that is could there be a stream that is acceptable to th
We only limit within the type itself, so it'd have to be very very particular about that stream and we'd need to have knowledge ahead of time. If we sent declined streams it has to decline them back, they can't be accepted. Can't really handle the particular scenario while still limiting streams.



-- 
To view, visit https://gerrit.asterisk.org/5876
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8afd8dd2eb538806a39b887af0abd046266e14c7
Gerrit-Change-Number: 5876
Gerrit-PatchSet: 11
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 22 Jun 2017 21:55:47 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170622/d4b6c19c/attachment.html>