[Asterisk-code-review] core local: local channel data not being properly unref'ed a... (asterisk[13])

Joshua Colp asteriskteam at digium.com
Wed Jun 21 13:28:47 CDT 2017


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5888 )

Change subject: core_local: local channel data not being properly unref'ed and unlocked
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5888/2/main/core_local.c
File main/core_local.c:

https://gerrit.asterisk.org/#/c/5888/2/main/core_local.c@274
PS2, Line 274: 		/* lock all locked the base and added a ref */
...what?

This comment hurts my head.



-- 
To view, visit https://gerrit.asterisk.org/5888
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice96653e29bd9d6674ed5f95feb6b448ab148b09
Gerrit-Change-Number: 5888
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 21 Jun 2017 18:28:47 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170621/62a1d840/attachment.html>


More information about the asterisk-code-review mailing list