[Asterisk-code-review] core local: local channel data not being properly unref'ed a... (asterisk[13])

Kevin Harwell asteriskteam at digium.com
Wed Jun 21 12:54:36 CDT 2017


Hello Richard Mudgett, Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/5888

to look at the new patch set (#2).

Change subject: core_local: local channel data not being properly unref'ed and unlocked
......................................................................

core_local: local channel data not being properly unref'ed and unlocked

In an earlier version of Asterisk a local channel [un]lock all functions were
added in order to keep a crash from occurring when a channel hung up too early
during an attended transfer. Unfortunately, when a transfer failure occurs and
depending on the timing, the local channels sometime do not get properly
unlocked and deref'ed after being locked and ref'ed. This happens because the
underlying local channel structure gets NULLed out before unlocking.

This patch reworks those [un]lock functions and makes sure the values that get
locked and ref'ed later get unlocked and deref'ed.

ASTERISK-27074 #close

Change-Id: Ice96653e29bd9d6674ed5f95feb6b448ab148b09
---
M include/asterisk/core_local.h
M main/bridge.c
M main/core_local.c
3 files changed, 77 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/88/5888/2
-- 
To view, visit https://gerrit.asterisk.org/5888
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ice96653e29bd9d6674ed5f95feb6b448ab148b09
Gerrit-Change-Number: 5888
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170621/6cee48f4/attachment.html>


More information about the asterisk-code-review mailing list