[Asterisk-code-review] res pjsip: Add DTMF INFO Failback mode (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5842 )

Change subject: res_pjsip:  Add DTMF INFO Failback mode
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/5842/2/channels/chan_pjsip.c
File channels/chan_pjsip.c:

https://gerrit.asterisk.org/#/c/5842/2/channels/chan_pjsip.c@1831
PS2, Line 1831: 			ast_debug(3, "digit_end for AST_SIP_DTMF_AUTO_INFO  -->  sending DTMF via RFC_4733 \n");
              : 			ast_rtp_instance_dtmf_end_with_duration(media->rtp, digit, duration);
              : 			break;
              : 		}
              : 		/* If RFC_4733 was not negotiated, fail through to the DTMF_INFO processing */
              : 		ast_debug(3, "digit_end for AST_SIP_DTMF_AUTO_INFO  -->  sending DTMF via INFO.\n") ;
These debug messages aren't useful as they are, they'd be better if they included the channel name. They also aren't easily readable, consider:

"Told to send end of digit on channel <name>, RFC4733 not negotiated so using INFO".


https://gerrit.asterisk.org/#/c/5842/2/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/#/c/5842/2/res/res_pjsip_sdp_rtp.c@343
PS2, Line 343: 		}
The else should go up here.


https://gerrit.asterisk.org/#/c/5842/2/res/res_pjsip_sdp_rtp.c@342
PS2, Line 342: 			ast_debug(3, "Setting dtmf mode to RFC2833\n");
             : 		}
             : 		else {
             : 			ast_rtp_instance_dtmf_mode_set(session_media->rtp, AST_RTP_DTMF_MODE_NONE);
             : 			ast_debug(3, "Setting dtmf mode to info\n");
Same here.


https://gerrit.asterisk.org/#/c/5842/2/res/res_pjsip_sdp_rtp.c@347
PS2, Line 347: 
Empty line



-- 
To view, visit https://gerrit.asterisk.org/5842
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Id185b11e84afd9191a2f269e8443019047765e91
Gerrit-Change-Number: 5842
Gerrit-PatchSet: 2
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 21 Jun 2017 17:02:30 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170621/5c2f2288/attachment.html>