<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5842">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5842/2/channels/chan_pjsip.c">File channels/chan_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5842/2/channels/chan_pjsip.c@1831">Patch Set #2, Line 1831:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                 ast_debug(3, "digit_end for AST_SIP_DTMF_AUTO_INFO  -->  sending DTMF via RFC_4733 \n");<br>                 ast_rtp_instance_dtmf_end_with_duration(media->rtp, digit, duration);<br>                      break;<br>                }<br>             /* If RFC_4733 was not negotiated, fail through to the DTMF_INFO processing */<br>                ast_debug(3, "digit_end for AST_SIP_DTMF_AUTO_INFO  -->  sending DTMF via INFO.\n") ;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">These debug messages aren't useful as they are, they'd be better if they included the channel name. They also aren't easily readable, consider:</p><p style="white-space: pre-wrap; word-wrap: break-word;">"Told to send end of digit on channel <name>, RFC4733 not negotiated so using INFO".</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/5842/2/res/res_pjsip_sdp_rtp.c">File res/res_pjsip_sdp_rtp.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5842/2/res/res_pjsip_sdp_rtp.c@343">Patch Set #2, Line 343:</a> <code style="font-family:monospace,monospace">                }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The else should go up here.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5842/2/res/res_pjsip_sdp_rtp.c@342">Patch Set #2, Line 342:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                    ast_debug(3, "Setting dtmf mode to RFC2833\n");<br>             }<br>             else {<br>                        ast_rtp_instance_dtmf_mode_set(session_media->rtp, AST_RTP_DTMF_MODE_NONE);<br>                        ast_debug(3, "Setting dtmf mode to info\n");<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5842/2/res/res_pjsip_sdp_rtp.c@347">Patch Set #2, Line 347:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Empty line</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5842">change 5842</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5842"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id185b11e84afd9191a2f269e8443019047765e91 </div>
<div style="display:none"> Gerrit-Change-Number: 5842 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 21 Jun 2017 17:02:30 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>