[Asterisk-code-review] chan pjsip: Multistream: Modify use of ast sip session media (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/5851 )

Change subject: chan_pjsip: Multistream: Modify use of ast_sip_session_media
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5851/4/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/5851/4/res/res_pjsip_session.c@298
PS4, Line 298: 				session_media->handler = NULL;
Should this be using "session_media_set_handler" to set the handler?


https://gerrit.asterisk.org/#/c/5851/4/res/res_pjsip_session.c@1068
PS4, Line 1068: 				session_media->handler = NULL;
Same in this spot (use "session_media_set_handler"?).

Also this section of code appears to be a duplicate of the other. If already modifying to fix the above (if it needs fixing) would it make sense to move this section to a shared function?



-- 
To view, visit https://gerrit.asterisk.org/5851
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I144b04f43633387b8e42a43ef3b25d7c5682b451
Gerrit-Change-Number: 5851
Gerrit-PatchSet: 4
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 21 Jun 2017 14:39:02 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170621/f7483774/attachment.html>