<p>Kevin Harwell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5851">View Change</a></p><p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5851/4/res/res_pjsip_session.c">File res/res_pjsip_session.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5851/4/res/res_pjsip_session.c@298">Patch Set #4, Line 298:</a> <code style="font-family:monospace,monospace">                                session_media->handler = NULL;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should this be using "session_media_set_handler" to set the handler?</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5851/4/res/res_pjsip_session.c@1068">Patch Set #4, Line 1068:</a> <code style="font-family:monospace,monospace">                            session_media->handler = NULL;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same in this spot (use "session_media_set_handler"?).</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also this section of code appears to be a duplicate of the other. If already modifying to fix the above (if it needs fixing) would it make sense to move this section to a shared function?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5851">change 5851</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5851"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I144b04f43633387b8e42a43ef3b25d7c5682b451 </div>
<div style="display:none"> Gerrit-Change-Number: 5851 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Mark Michelson <mmichelson@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Mark Michelson <mmichelson@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 21 Jun 2017 14:39:02 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>