[Asterisk-code-review] bridge native rtp: Keep references to rtp instances on hook... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/5854 )

Change subject: bridge_native_rtp:  Keep references to rtp instances on hook data
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/5854/1/bridges/bridge_native_rtp.c
File bridges/bridge_native_rtp.c:

https://gerrit.asterisk.org/#/c/5854/1/bridges/bridge_native_rtp.c@195
PS1, Line 195: 		ast_debug(2, "Locally RTP bridged '%s' and '%s' in stack\n",
             : 			ast_channel_name(bc0->chan), ast_channel_name(bc1->chan));
             : 		ast_verb(4, "Locally RTP bridged '%s' and '%s' in stack\n",
             : 			ast_channel_name(bc0->chan), ast_channel_name(bc1->chan));
> Do we really need identical debug and verbose messages? Meaning
 > should we leave the one or drop the other?

The problem is that turning on verbose gets a ton of messages and these are existing messages I don't want to remove.  This way the existing messages aren't messed with and if you're debugging, you can just set debug on bridge_native_rtp without getting flooded with verbose messages.


https://gerrit.asterisk.org/#/c/5854/1/bridges/bridge_native_rtp.c@532
PS1, Line 532: 		ao2_ref(data->audio_instance, -1);
             : 		ao2_ref(data->video_instance, -1);
> These shouldn't be here. The hook_data_destructor take care of  unref'ing t
Oops, yeah you're right.



-- 
To view, visit https://gerrit.asterisk.org/5854
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e1ac49fa4af68d64826ccccd152593cf8cdb21a
Gerrit-Change-Number: 5854
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 19 Jun 2017 15:52:57 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170619/93aa1677/attachment.html>