<p>George Joseph <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5854">View Change</a></p><p>Patch set 1:</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5854/1/bridges/bridge_native_rtp.c">File bridges/bridge_native_rtp.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5854/1/bridges/bridge_native_rtp.c@195">Patch Set #1, Line 195:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">          ast_debug(2, "Locally RTP bridged '%s' and '%s' in stack\n",<br>                        ast_channel_name(bc0->chan), ast_channel_name(bc1->chan));<br>              ast_verb(4, "Locally RTP bridged '%s' and '%s' in stack\n",<br>                 ast_channel_name(bc0->chan), ast_channel_name(bc1->chan));<br></pre></blockquote></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Do we really need identical debug and verbose messages? Meaning<br>should we leave the one or drop the other?</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">The problem is that turning on verbose gets a ton of messages and these are existing messages I don't want to remove.  This way the existing messages aren't messed with and if you're debugging, you can just set debug on bridge_native_rtp without getting flooded with verbose messages.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5854/1/bridges/bridge_native_rtp.c@532">Patch Set #1, Line 532:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">             ao2_ref(data->audio_instance, -1);<br>         ao2_ref(data->video_instance, -1);<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">These shouldn't be here. The hook_data_destructor take care of  unref'ing t</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Oops, yeah you're right.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5854">change 5854</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5854"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9e1ac49fa4af68d64826ccccd152593cf8cdb21a </div>
<div style="display:none"> Gerrit-Change-Number: 5854 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 19 Jun 2017 15:52:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>